[Task]: Move astro and daylength from utils to WeatherDataProvider
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 25
- Forks
- 6
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 1
Description
Two functions astro and daylength are called in modules assimilation and phenology while simulations runs. But, they could be run once ouside of the crop modules and the results can be passed via WeatherDataProvider to the crop modules. Related issue #91.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading related issue #91, then trace the astro and daylength calls from the assimilation and phenology modules into utils and WeatherDataProvider. Confirm where simulations compute these values and how crop modules receive weather data. Done means the functions are computed outside the crop modules and their results are passed through WeatherDataProvider without changing simulation behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100