WICG / WICG/webpackage

Function signature change: reading all bytes from a stream

Open
#839 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
1.3k
Forks
125
PR merge metrics
No merged PRs in 30d

Description

The signature of reading all bytes had changed:
https://github.com/whatwg/streams/pull/1250

It now accepts successSteps and failureSteps instead of returning a Promise, in an attempt to decouple streams from JS when appropriate.

Opening this issue since this spec uses that function

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for uses of the “reading all bytes” function, then read WHATWG Streams pull request #1250 to understand the updated signature. Update the repository’s use to pass successSteps and failureSteps instead of relying on a returned Promise, and verify that no outdated references remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.