WICG / WICG/webpackage

Go: Avoid mutating (signedexchange.Exchange).Payload

Open
#431 0 comments 0 reactions 3 assignees View on GitHub

@irori is already working on this.

Since May 3, 2019.

go
Dominant language
Go
Stars
1.3k
Forks
125
PR merge metrics
No merged PRs in 30d

Description

cc: @twifkak

In the current code, the Payload []byte field may contain payload either before or after mice encoding.
This is confusing behavior and we should avoid.

Perhaps we should factor out other Exchange members to a separate struct.
#427 would also benefit from such change.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.