Remove DiffProposal objects, use Proposal instead
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2
- Forks
- 0
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 1
Description
Remove Diff and use regular proposal instead. No reason to have several objects, add attributes instead.
WAS:
Reactions for DiffProposal objects point to the wrong object
We're pointing them to the base proposal object, but they should point to the main diffproposal object with the same PK.
This causes reactions to deleted diffproposals to remain in the database.
- Create migration
- Update export / import scripts
- Create rest-interface for reactions instead of using message queues
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the DiffProposal and Proposal models, then trace reaction persistence and the export/import scripts. Review how deleted DiffProposal records are handled and identify the migration and REST reaction entry points. Done means the duplicate object is removed, reactions target the correct proposal, migration and import/export work, and reactions no longer remain after deletion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, database
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100