Appstate returned from subscribe commands should be a bit smarter
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 2
- Forks
- 0
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 1
Description
- Leave channel-command returns a response with a timestamp when the user left
- Subscribe should accept the timestamp (optional) as an argument and only fetch messages later than that ts
- Problem: If something was deleted when the user wasn't subscribed. So, introduce a new deleted state instead of deleting objects. See #116 and do that one first (model_utils contains tools for this too) Alternate route: Store deleted primary keys of different models.
- Make sure deleted PKs gets pushed when subscribing with timestamp
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with issue #116, which this issue says should be completed first, and inspect the tools in model_utils. Then trace the leave-channel and subscribe commands to understand their current appstate responses and message fetching. Done means implementing the timestamp flow and preserving or reporting deleted primary keys when subscribing with a timestamp, as described in the checklist.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100