VisionSystemsInc / VisionSystemsInc/vsi_common
Refactor findin/isin/etc...
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 8
- Forks
- 9
- Avg merge
- 36m
- Merged PRs (30d)
- 1
Description
Having these functions in executable callable form was set up a long time ago, and is possibly unnecessary
Should all these functions be combined into one files, (maybe elements.bsh ?)
This can be done in two steps to maintain compatibility. First move to the new file, and leave the current existing findin, etc... with a deprecation warning (on source), and then remove those at a later date.
Thoughts? @scott-vsi
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the executable functions named findin, isin, and the related commands in the repository. Review whether they can be combined into a file such as elements.bsh while preserving existing callers. The first stage is complete when the old entry points emit deprecation warnings and compatibility remains intact; later removal is a separate stage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100