VisActor / VisActor/VChart

[Bug] press event not working

Open
#4,163 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug interaction
Dominant language
TypeScript
Stars
1.8k
Forks
221
Avg merge
1d 6h
Merged PRs (30d)
26

Description

Version

2.0.0

Link to Minimal Reproduction

null

Steps to Reproduce
const spec = {
  type: 'line',
  data: {
    values: [
      {
        time: '2:00',
        value: 8
      },
      {
        time: '4:00',
        value: 9
      },
      {
        time: '6:00',
        value: 11
      },
      {
        time: '8:00',
        value: 14
      },
      {
        time: '10:00',
        value: 16
      },
      {
        time: '12:00',
        value: 17
      },
      {
        time: '14:00',
        value: 17
      },
      {
        time: '16:00',
        value: 16
      },
      {
        time: '18:00',
        value: 15
      }
    ]
  },
  xField: 'time',
  yField: 'value'
};

const vchart = new VChart(spec, { dom: CONTAINER_ID });
vchart.renderSync();

VCHART_MODULE.registerGesturePlugin()

vchart.on('press', () => {
  confirm('press')
})
// vchart.on('click', () => {
//   confirm('click')
// })


// Just for the convenience of console debugging, DO NOT COPY!
window['vchart'] = vchart;
Current Behavior

Press event will not be triggered.

Expected Behavior

Trigger press event after interaction.

Environment
- OS:
- Browser:
- Framework:
Any additional comments?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the gesture plugin registration and the vchart.on('press', ...) listener shown in the reproduction, then compare its behavior with the commented click listener. Confirm the press interaction is delivered for this line-chart setup and that the expected callback fires after the fix.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data-visualization, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.