Vinyzu / Vinyzu/Botright

[BUG] socks5 proxy

Open
#15 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug help wanted
Dominant language
Python
Stars
1k
Forks
85
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/botright.py", line 26, in new_browser
    _proxy = await ProxyManager(self, proxy)
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/async_class.py", line 173, in __await__
    yield from self.create_task(
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/modules/proxy_manager.py", line 28, in __ainit__
    self.split_proxy()
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/modules/proxy_manager.py", line 68, in split_proxy
    raise SplitError(f"Proxy Format ({self.proxy}) isnt supported")
tsup.botright.modules.proxy_manager.SplitError: Proxy Format (socks5://127.0.0.1:1080) isnt supported

Code Sample
If applicable, add a code sample to replicate the bug.

To Reproduce

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in tsup/botright/modules/proxy_manager.py at split_proxy(), then inspect its call from tsup/botright/botright.py. Reproduce the failure with the reported socks5://127.0.0.1:1080 proxy; done means that supported input no longer raises SplitError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.