VictoriaMetrics / VictoriaMetrics/operator

vmcluster: support `extraStorageNodes` for vmselect and vminsert

Open
#1,701 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
589
Forks
229
Avg merge
1d 9h
Merged PRs (30d)
77

Description

Currently, using multi-level deployments require to define additional storage nodes via {vmselect/vminsert}.extraArgs.storageNodes.
That is error prone as changes in number of storage nodes needs to be reflected for these flags as well.

VLCluster and VTCluster resources support extraStorageNodes which allows to add an additional list of storage nodes automatically, so that it is easier change number of storage nodes without changing other parameters. It would be great for VMCluster to support the same parameter.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing VMCluster’s vmselect and vminsert handling of extraArgs.storageNodes with the existing VLCluster and VTCluster extraStorageNodes support. Trace the resource fields and reconciliation path, then inspect the relevant operator tests. Done means VMCluster accepts extraStorageNodes and automatically incorporates the listed storage nodes without requiring matching storageNodes flags.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
67/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.