Vector35 / Vector35/binaryninja-api
Cancelling opening a database does not work
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Version and Platform (required):
- Binary Ninja Version:
5.4.9506-dev
Bug Description:
When you cancel opening a database in the progress dialog, the database is still opened, just with a few cancellation messages in the log
Steps To Reproduce:
Please provide all steps required to reproduce the behavior:
- Open any database large enough to trigger the progress dialog
- Click
Cancel - Notice the database is opened anyway
Expected Behavior:
Cancelling opening the database should not result in the database being opened
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by opening a database large enough to show the progress dialog, then click Cancel and observe that it still opens. Trace the progress-dialog cancellation path and database-opening entry point to determine where cancellation is ignored; done means canceling prevents the database from opening and the behavior is covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- databases, reverse-engineering
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100