Vector35 / Vector35/binaryninja-api
Redundant Size Suffixes
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Version and Platform (required):
- Binary Ninja Version: 5.3.9208
- Edition: Ultimate
- OS: OSX
- OS Version: 26.3
- CPU Architecture: M3
Bug Description:
(There are two bugs here) When using the magic structure creation workflow on the following binary (starting at the malloc call at the end of the first basic block), Binary Ninja creates a double on a field that's used in a four-byte assignment and a 4-byte read. It then renders those reads as var.d.d (which is the bug I'm filing for).
Steps To Reproduce:
- Open attached binary
- Click
son themallocnear the end of the first basic block - Press
son the rest of the offset annotations - Renders redundant
.d's on accesses
Expected Behavior:
We should only show one .d
Screenshots/Video Recording:
Binary:
structure.elf.zip
Additional Information:
When you correct the type to a float from a double, it renders correctly. But I feel like we shouldn't ever display .d.d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open the attached structure.elf.zip in Binary Ninja 5.3.9208 and reproduce the issue through the magic structure creation workflow, starting at the malloc near the end of the first basic block and applying the offset annotations. Inspect how the double type is created for the four-byte assignment and read. Done when those accesses render a single .d rather than var.d.d.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- reverse-engineering
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100