Vector35 / Vector35/binaryninja-api

Improve function inliner to continue inlining at basic blocks that fallthrough to other functions

Open
#7,962 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

The function inliner should check for fallthrough blocks and continue inlining the function that the block falls through to. See the screenshot below. Currently, if the user inlines _restgpr_27_x the inliner only inlines the basic block from _restgpr_27_x and doesn't inline _restgpr_28_x, _restgpr_29_x, and so-on.

Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named. Locate the function inliner and its handling of basic-block fallthrough, then reproduce the _restgpr_27_x case; done means inlining also follows _restgpr_28_x, _restgpr_29_x, and subsequent fallthrough functions.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.