Vector35 / Vector35/binaryninja-api

Confusing experience deleting files in remote project

Open
#7,955 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Collaboration Edition: Ultimate Effort: Trivial Impact: Low UI: Projects
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

When deleting a file in a project with no permissions the behavior is odd:

  1. It deletes the file on disk
  2. It removes the file from the project?
  3. It says that I have no permission to delete the file

https://github.com/user-attachments/assets/71f29e11-9904-47ea-b5c1-233f919e7d12

We should be checking if the user has permissions to delete the file before making any destructive changes to the project as it exists locally.

Additionally, all the logs should be scoped to some actual name rather than the default log, makes it difficult to ascertain what system is having problems (is it project support in general, or collaboration).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the remote-project file deletion flow and identify where permission checks occur relative to local and project changes. Done means unauthorized deletion makes no destructive changes and logs identify the affected system rather than using the default log.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
authorization, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.