Vector35 / Vector35/binaryninja-api
Missing break statement causes unintended fall-through from case MIPS_DSRLV to case MIPS_MMI0
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Version and Platform :
- Binary Ninja Version: 5.0.7648
- Edition: Commercial
- OS: MacOS
- OS Version: 15.1.1
- CPU Architecture: [M4]
Bug Description:
when I compile the arch-mips plugin I find it could not disassemble DSRLV correctly. Then I found Missing break statement causes unintended fall-through from case MIPS_DSRLV to case MIPS_MMI0 in the binaryninja-api code, caused by https://github.com/Vector35/binaryninja-api/commit/da9df164ea310ee6aab900fa940b63d20839c2dc#diff-abc4a7fb962fb647aec8ffc030e7600446fd51186f56a3eb14fe18159c715649
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the MIPS instruction dispatch in the binaryninja-api code, using commit da9df164ea310ee6aab900fa940b63d20839c2dc and the arch-mips plugin as entry points. Compile the plugin and test disassembly of DSRLV; done means DSRLV no longer falls through to MIPS_MMI0 and is decoded correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- reverse-engineering
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100