Export `FlowGraph::AbortIfRequested`

Open
#7,826 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
api

Research direction

Start in binaryninjaapi.h at the FlowGraphLayoutRequest::Abort() and FlowGraph::AbortIfRequested() declarations referenced in the issue. Read the internal AbortIfRequested implementation to understand its flag handling, then expose the provider-facing check while preserving the intended abort behavior.

Written by the indexing model from the issue text.

Description

Component: API Component: Core Effort: Trivial Impact: Medium UI: Graph

We allow users to implement their own flow graph layout providers and we allow users to request flow graph layouts (positioning of nodes within a flow graph). The issue is that we do not allow for flow graph layout providers to be cancelled/aborted, we export FlowGraphLayoutRequest::Abort() but no way to check if the request has been aborted.

https://github.com/Vector35/binaryninja-api/blob/ba13f6ec7d0ce9a18a03a1c895fb72d18e03014a/binaryninjaapi.h#L13339

https://github.com/Vector35/binaryninja-api/blob/ba13f6ec7d0ce9a18a03a1c895fb72d18e03014a/binaryninjaapi.h#L13605

We have this internally, a function called AbortIfRequested. It might be beneficial to also understand the internals of that function before trying to expose it, seeing as it also forces flags other than the "is aborted" flag.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.