Vector35 / Vector35/binaryninja-api

Missing ssa_version for Mapped MLIL SSA_FORM

Open
#7,607 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 5.1.8005
  • Edition: Non-Commercial
  • OS: arch linux
  • CPU Architecture: x64

Bug Description:
The ssa_version field of a Variable does not work if the current il_form is mapped mlil_ssa_form (FunctionGraphType.MappedMediumLevelILSSAFormFunctionGraph). Only non-mapped mlil and mlil_ssa_form are supported.

Relevant code from plugins/python/binaryninja/variable.py:

	@property
	def ssa_versions(self) -> Generator[int, None, None]:
		"""Returns the SSA versions associated with this variable. Doesn't return anything for aliased variables."""
		if self._il_function is None:
			raise NotImplementedError("No IL function associated with variable")

		version_count = ctypes.c_ulonglong()
		if self._il_function.il_form in [
		    FunctionGraphType.MediumLevelILFunctionGraph, FunctionGraphType.MediumLevelILSSAFormFunctionGraph
		]:
			versions = core.BNGetMediumLevelILVariableSSAVersions(
			    self._il_function.handle, self.to_BNVariable(), version_count
			)
                ...
		else:
			raise NotImplementedError("Unsupported IL form")

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in plugins/python/binaryninja/variable.py at the ssa_versions property and trace how il_form is checked for MLIL and MLIL SSA form. Compare the mapped MLIL SSA form path with the supported forms, then verify that requesting SSA versions for a mapped MLIL SSA variable no longer raises Unsupported IL form.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
reverse-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.