Vector35 / Vector35/binaryninja-api

Render issue with tabs in comments

Open
#7,598 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Effort: Low Impact: Low UI: Linear
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 5.2.8559-dev (c4f13e43)
  • Edition: Commercial
  • OS: macOS
  • OS Version: 15.5
  • CPU Architecture: M1

Bug Description:
Comments that contain tabs are not rendered correctly. This is the case for both comments in a function body, as well for the function itself.

Steps To Reproduce:

  1. Create a function comment with the following content:
	1 Foo
	2 Bar
	3 Baz

The space before the numbers is a tab.
2. Observe the comment text isn't aligned as expected.

Expected Behavior:
The numbers after the tabs should be aligned.

Screenshots/Video Recording:
A function comment when rendered:

Image

The function comment when editing it:

Image

Additional Information:
This is might be the same as #5972.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in a function comment and in a comment within a function body using the tab-indented example on macOS. Compare the rendered output with the editing view, and review related issue #5972 for context. Done means tabs align the numbers consistently in both comment locations.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.