Vector35 / Vector35/binaryninja-api

Modals opening on different monitor

Open
#7,503 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Low Impact: Medium UI: Dialogs
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version:5.1.8104 Personal (6eaaf348)
  • Edition: Non-Commercial
  • OS: WIndows
  • OS Version: 11
  • CPU Architecture: x64

Bug Description:
When opening modals, the program opens them on my second monitor. When I drag the modal to use it to my main monitor and finish by clicking close or accept, it does not save the monitor it was closed on and just reopens on the other monitor again.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Go to Types manager
  2. Click on a type to rename and press N
  3. Modal appears on second monitor
  4. Drag modal to primary monitor
  5. Rename type and press Accept
  6. Repeat step 2, and modal opens on secondary monitor again

Expected Behavior:
The modal location or at least what monitor it was on when it closed should be saved, and it should reopen on that monitor again.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Types manager flow described in the reproduction steps and investigate how the rename modal is opened and closed on Windows 11 with multiple monitors. Reproduce the issue, then verify that after moving the modal to the primary monitor and accepting a rename, the next rename modal opens on that monitor.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.