Vector35 / Vector35/binaryninja-api

Renaming local variables will also affect the variable names in the code block

Open
#7,469 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 5.2.8363-dev
  • Edition: Non-Commercial
  • OS: Windows11
  • OS Version: 24H2
  • CPU Architecture:x64

Bug Description:
I want to rename the variable to IoControlCode_1, but in the if statement, it should be another name SystemBuffer, which I can't do. When I rename it to IoControlCode_1, SystemBuffer will also be affected. I want to mark it as two different variable names without conflict.

Steps To Reproduce:
Rename rcx_1 to IoControlCode_1 then rename IoControlCode_1 to SystemBuffer

Expected Behavior:

Screenshots/Video Recording:

Image

Binary:
If applicable, please provide us with the binary to help us work with the issue faster. Here are a few options:

Your reference phrase:
plasma gradient renders joyfully

  1. Upload it privately using the Binary Ninja Portal file uploader and add the provided reference phrase here.
  2. Directly attach it to this issue in a ZIP archive
  3. Share a publicly accessible link to it (For malware samples, we do not have access to VirusTotal; Malshare is an option)
  4. Email it to binaryninja at vector35.com, or join our Slack and share it with us in private
  5. We understand sometimes it is not possible to share the binary -- sure, no worries, we can still work with it!
  6. If your issue is general and not related to a specific binary, then there is no need to attach the binary as well

Additional Information:
Please add any other context about the problem here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is identified. Start by reproducing the rename sequence from rcx_1 to IoControlCode_1 and then SystemBuffer in the reported Windows 11 environment; done means the two intended variables can retain distinct names without one rename changing the other.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.