Vector35 / Vector35/binaryninja-api
Improved Disassembly Annotation of Offset Pointers
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Version and Platform (required):
- Binary Ninja Version: 5.2.8150-dev Ultimate, c461f5cf
- OS: macos
- OS Version: 15.6
- CPU Architecture: x86_64
Bug Description:
The new, corrected types that include linked lists now allow for completely correct IL views, but there are still some gaps in the annotations in disassembly views. A few versions ago, there were more annotations, but they were wrong due to #6492 . This has been fixed, but now there are no annotations where the wrong ones were before, and there are still some locations that seem like they should have annotations that were not there before and also are not there now.
Steps To Reproduce:
See #6492
Expected Behavior:
There should be annotations in the same places as before, but they should now be correct. I also think there should be annotations at 0x778 and 0x763, but I could be wrong about that and I'm open to correction.
Screenshots:
Before #6492 fix
After #6492 fix
Binary:
See #6492
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with issue #6492 and its referenced binary, then compare the before-and-after disassembly screenshots to identify where annotations disappeared. Determine whether annotations should also appear at 0x778 and 0x763; done means restoring the previously expected annotations with correct offset-pointer information.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- reverse-engineering
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100