Vector35 / Vector35/binaryninja-api
Can't actually cancel opening a project while offline
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Version and Platform (required):
- Binary Ninja Version: 5.1.7982-dev
- Edition: Ultimate
- OS: macOS
- OS Version: 15.5
- CPU Architecture: aarch64
Bug Description:
You can't actually cancel the "Open Project" modal from the Remote Dialog:
You can mash the cancel button all you want, but you still need to wait for the entire 1s + 2s + 4s timeout to happen.
Steps To Reproduce:
- Connect to an Enterprise server
- Disrupt your connection without logging out or closing Binja
- Try and open a project from the Remote Dialog
- Observe issue (you can see the retries in the log)
Expected Behavior:
The operation cancels when I hit cancel.
Additional Information:
Not a release blocker by any stretch, just observed this during testing and wanted to make note of it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Remote Dialog flow used when opening a project and reproduce the offline connection failure while watching the retry log. Trace how the Cancel button interacts with the 1s, 2s, and 4s retries; done means cancellation stops the operation without waiting for all timeouts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100