Vector35 / Vector35/binaryninja-api

Analysis does not create string data variable despite the presence of xref

Open
#7,121 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Core Effort: Low Impact: Low
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

In the following screenshot, there is a string at 0x100644c92 that is HNC_THEME_CHANGED

Image

We can see there is an xref to it:

Image

The string is also correctly detected:

>>> bv.get_string_at(0x100644c92)
<Utf16String: 0x100644c92, len 0x22>

But we do not create a string data variable at it

P.S.: in stable 5.0, we create void data variables at the start of the strings, which is still not the expected behavior

Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the case at 0x100644c92 and inspect the result of bv.get_string_at(0x100644c92), comparing current behavior with stable 5.0. Trace how an xref to a detected Utf16String is handled and verify whether the expected string data variable is created instead of no variable or a void variable. Done means the referenced string receives the correct data variable type without regressing existing analysis.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.