Vector35 / Vector35/binaryninja-api

Globals are missing when pulling from Enterprise server

Open
#7,115 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Core Edition: Ultimate Impact: Medium
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 5.0.7648
  • Edition: Ultimate
  • OS: any

Bug Description:
When a user pushes snapshots to the Enterprise server, we don't push globals. So, if another user pulls those snapshots, they will not see things like bv.file.original_filename.

Steps To Reproduce:

  1. Create a new database in a remote project
  2. Observe that bv.file.original_filename exists (although, you may also run into #7074)
  3. Push that database to the Enterprise server
  4. In another client with a separate user folder (or on a different machine), pull that database
  5. Observe that bv.file.original_filename is not set

Expected Behavior:
Users expect that some of these globals will exist when pulling files from the server.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the listed remote-project steps, checking bv.file.original_filename before pushing and after another client pulls the database. Start by tracing the Enterprise server snapshot push and pull paths, then verify that the expected globals are present for a separate user folder or machine after the fix.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend-api-design, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.