Vector35 / Vector35/binaryninja-api
UIDF Dialog populates user value with incorrect displayed destination
Open
Nobody has claimed this yet.
Component: UI
Core: Dataflow
Effort: Low
Impact: Medium
UI: Dialogs
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Bug Description:
The UIDF dialogue at times populates set user values with an incorrectly displayed dest
Steps To Reproduce:
Please provide all steps required to reproduce the behavior:
- Open the attached bndb in HLIL
- Right click > set user variable value on rsi at its assignment to var_10
- Notice the ASSERT() points to argv as the dest for whatever set variable value, which is technically not incorrect because argv corresponds to rsi, but should point to rsi.
Expected Behavior:
The ASSERT() should appear the same except should have rsi displayed as the dest.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the attached bndb in HLIL and follow the reproduced UIDF dialog flow for “set user variable value” on rsi at its assignment to var_10. Confirm the displayed ASSERT() destination currently shows argv, then verify that the completed change displays rsi instead.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- reverse-engineering
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100