Vector35 / Vector35/binaryninja-api

Add new InstructionTextTokenType for HLIL inline argument names

Open
#6,969 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Trivial Impact: Medium
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

What is the feature you'd like to have?
The tokens that are rendered in HLIL for function call argument names are simple TextTokens. They should have a new TokenType.

Is your feature request related to a problem?
It is impossible to theme them given you cannot uniquely address them.

Are any alternative solutions acceptable?
Could reuse another existing token type but that is kind of gross.

Additional Information:
Reported by Thomas Atkins on Slack

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the InstructionTextTokenType definition and the HLIL rendering entry point for function-call argument names. Confirm how those names are currently emitted as TextTokens, then make the token uniquely themeable and verify that HLIL output exposes the new type.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.