Vector35 / Vector35/binaryninja-api
Improvements to Secrets Storage
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
What is the feature you'd like to have?
Implement all of these options:
- Back the
hiddenproperty type for Settings withbinaryninja.secretsproviderautomatically - Make a new Settings property type
secretbacked withbinaryninja.secretsproviderautomatically - Add a flag to
binaryninja.interaction.get_text_line_inputthat hides the input with circles like the hidden setting does and have an eye icon in there to show it if needed.
Is your feature request related to a problem?
binaryninja.settings has a nice "hidden" feature for storing secrets, but it stores the actual secret with the other settings.
Alterntively, you can store secrets yourself using binaryninja.secretsprovider but the input widgets don't hide the text of the secret being entered.
Improve all of these to make a complete solution for secrets (like API keys).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing hidden property in binaryninja.settings and its use of binaryninja.secretsprovider, then inspect binaryninja.interaction.get_text_line_input. Done means hidden settings use the secrets provider, a secret property type is available, and text-line input can hide and optionally reveal entered text.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100