Vector35 / Vector35/binaryninja-api

`__builtin_memset` intrinsic call in MLIL may have incorrect parameter types

Open
#6,707 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Core Core: MLIL Effort: Medium Impact: Medium
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 5.0.7289-test Ultimate (96bf77cd)
  • OS: Debian
  • OS Version: trixie
  • CPU Architecture: x64

Bug Description:
In some cases, function call argument types have a width incompatible with the formal parameter width. I've mostly seen this happen with __builtin_memset lifted from rep stosb.

Steps To Reproduce:
Open the binary with default settings, then run:

>>> func = bv.get_function_at(0x400000)
>>> func.mlil.ssa_form[3].dest.expr_type.target.parameters[1].type
<type: immutable:IntegerTypeClass 'int32_t'>
>>> func.mlil.ssa_form[3].params[1].expr_type
<type: immutable:IntegerTypeClass 'char', 0% confidence>

Expected Behavior:
The constant 0 should have a type int32_t, or a cast should be inserted.

Binary:
bug.zip

Additional Information:
This isn't visible in the UI at all but breaks a tool I'm developing that is sensitive to accuracy of type information in MLIL.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the supplied bug.zip using the Python API entry points func.get_function_at, func.mlil.ssa_form, and the shown expr_type fields. Inspect how the __builtin_memset call and its second argument are typed; done means the constant 0 has type int32_t or an explicit cast is present.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.