Vector35 / Vector35/binaryninja-api

`set_worker_thread_count` cannot be set to 1

Open
#6,652 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Core Effort: Low Impact: Low
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

What is the feature you'd like to have?
When we fixed #5170, we did so by preventing the worker thread count from being set to a value less than 2. We should revisit that, since my understanding is the change was made more for expediently resolving the situation than a fundamental technical limitation.

Is your feature request related to a problem?
A number of customers are trying to quickly process a large number of binaries in parallel and being able to confine each one to a single thread in headless is desirable for throughput. Additionally, being able to force things to be a little more deterministic might be helpful in certain situations.

Are any alternative solutions acceptable?
If I'm wrong and this is a more fundamental technical limitation, we should try and document why that is, prevent the setting from being set to 1 more obviously, and provide a warning if you try.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the set_worker_thread_count entry point and review the change described in issue #5170. Determine whether a count of 1 can work for headless processing and, if so, define the expected behavior; otherwise document the technical limitation and ensure attempts to use 1 are clearly handled.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance, reverse-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.