Vector35 / Vector35/binaryninja-api

Copying text in the types widget type definition box sometimes misses the final character

Open
#6,520 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Trivial Impact: Low UI: Types
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 4.3.7094-dev (0f9d9b3f)
  • OS: macOS
  • OS Version: 15.2
  • CPU Architecture: M1

Bug Description:
When highlighting part of a word or line in the types widget in the type definition box, and copying it to the clipboard the last character is not copied. Sometimes it can occur when highlighting the entire word or line but that seems to be less likely. I've noticed that copying works correctly when highlighting does the snapping feature when it will snap to cover the whole word or line.

Steps To Reproduce:

  1. Go to the types widget.
  2. Select any type to view its type definition.
  3. Highlight part of any word but make sure it doesn't snap to highlight the entire word.
  4. Copy the text using right-click copy or using the OS copy keyboard shortcut.
  5. Paste the text in the Python console and notice the final character was not copied.

Expected Behavior:
Copies all of the highlighted text into the clipboard.

Additional Information:
This bug has been around for a long time its just minor enough I haven't bothered reporting it until now. Occassionally gets me when copying type names.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the types widget and its type definition box, then reproduce the selection and copy steps on macOS. Compare partial selections with word- or line-snapped selections, including both context-menu and keyboard copying. Done means every highlighted character, including the final one, appears when pasted into the Python console.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.