navigation should maintain token highlights

Open
#6,241 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cpp
Domain
reverse-engineering

Research direction

The issue names no files, tests, or entry points. Trace navigation and cross-reference handling alongside token-highlight state, then verify that navigation preserves the previous token selection without requiring the larger refactor to target the actual token.

Written by the indexing model from the issue text.

Description

Component: UI Effort: Low Impact: Medium UI: Cross References

When you navigate (including following a cross-reference for example), the token highlights should be maintained.

Right now if you follow a cross-reference, the previous token selection isn't maintained. This makes you lose visual anchoring of what you had selected.

Ultimately, it would be great if navigation via xref could navigate to the actual token itself and maintain the primary highlight selection but that requires a refactor of the navigation system so we'll see how well this much simpler change is at helping users maintain context when navigating before we consider that.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.