Vector35 / Vector35/binaryninja-api

Add confirmation dialog when making External Link to non-BNDB

Open
#6,120 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Projects Effort: Trivial Impact: Low UI: Projects
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

What is the feature you'd like to have?
Users can make external links within a project directly to e.g. a .dll. This is probably not what they want to do and we should make sure it is with a confirmation dialog.

I'm thinking something like:

"You are making an external link to a raw file, rather than an analysis database (.bndb). Are you sure this is what you want to do?"

Checkbox: "Do not show this warning again for this analysis database" -> save into BNDB/QSettings

Buttons: Yes, No (save state of checkbox always, proceed or cancel depending on which button was pressed)

Is your feature request related to a problem?
Customers are annoyed when they double-click an external link to follow it and then have to suffer re-analysis on a big shared library. This shouldn't be what happens in most cases because they should link against a BNDB instead, but we allow them to link to the raw file, which may be what a user wants in specific cases, but not the general case.

Are any alternative solutions acceptable?
Anything that avoids having long analysis times when following an external link is potentially fine.

Additional Information:
Please add any other context or screenshots that would help us understand your feature request here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test path is identified. Start by locating the external-link creation or following entry point and the existing BNDB/QSettings persistence; done means non-BNDB raw-file links show a confirmation dialog, honor the per-analysis-database checkbox, and proceed or cancel according to the selected button.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop, reverse-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.