Vector35 / Vector35/binaryninja-api

Escape key doesn't clear filter box in Find results sidebar (it does in the Strings view)

Open
#6,083 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Low Impact: Low UI: Find Results
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 4.2.6345-dev Ultimate (2f4145a2)

Bug Description:
Hitting Esc key while in the filter textbox of the Find results sidebar does not clear its contents.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Use Find with "Find all" checked
  2. Expand Filter above search results
  3. Type something into "Search text" box
  4. Hit Escape key, observe that the filter text box contents are not cleared

Expected Behavior:
The filter text box contents should be cleared when Escape key is pressed with the filter text box active.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named. Start by locating the Find results sidebar filter textbox and compare its Escape-key handling with the Strings view. Done means pressing Escape while the filter box is active clears its contents, while the documented Find-all and filter steps continue to work.

Written by the indexing model from the issue text.

Assessment

Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.