Vector35 / Vector35/binaryninja-api
Undoing setting a function's type makes the initial auto type into a user type
Open
Nobody has claimed this yet.
Component: Core
Effort: Trivial
Impact: Low
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Instead of resetting the function's type to the auto defined function type, it set as a user type
>>> current_function.has_user_annotations
False
>>> current_function.stack_adjustment = current_function.stack_adjustment
>>> current_function.has_user_annotations
True
>>> bv.undo()
>>> current_function.has_user_annotations
True
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproducer in the issue, focusing on function type assignment and the undo operation around stack_adjustment. Trace how undo restores the function's automatically defined type and verify that has_user_annotations returns to False after undo.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api, reverse-engineering
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100