Vector35 / Vector35/binaryninja-api

Improper return register selection for x86 xmm0

Open
#5,908 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Core Core: HLIL Effort: Medium Impact: Medium
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 4.2.6039-dev Personal (d2968e13)

Bug Description:
This basic block seems to be decompiled wrong, with temp[0] being introduced and going nowhere:

Screenshot_20240906_234317
Screenshot_20240906_234517

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Open libDly_DelayCalculator.so
  2. Go to 0x00074ed2
  3. Rotate through views

Expected Behavior:
An arithmetic expression is assembled from LLIL fragments and returned.

Binary:
libDly_DelayCalculator.so.zip

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open libDly_DelayCalculator.so, navigate to 0x00074ed2, and rotate through the available views to reproduce the incorrect decompilation. Compare the displayed basic block with its LLIL fragments and investigate why temp[0] is introduced; done means an arithmetic expression is assembled from the fragments and returned.

Written by the indexing model from the issue text.

Assessment

Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.