Vector35 / Vector35/binaryninja-api

Define Binary Ninja Macros Persistence or Setting

Open
#5,894 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Effort: Trivial Impact: Low
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

What is the feature you'd like to have?

Add setting to enable "Define Binary Ninja Macros" by default when selecting "Analysis > Import Header File"

Screenshot 2024-08-29 at 08 14 19

Is your feature request related to a problem?

N/A

Are any alternative solutions acceptable?

  • Remember the setting each time, i.e. make it persistent.
  • Just clicking it each time. ☹️

Additional Information:

I keep most of my type definitions in a C library for easy source control. I make heavy use of the Binary Ninja macros which define the C type qualifiers, like __padding. This definition isn't found by the parser if "Define Binary Ninja Macros" isn't checked.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the UI entry for Analysis > Import Header File and the code that handles the “Define Binary Ninja Macros” checkbox. Determine whether the setting should persist or default to enabled; done when the chosen behavior is retained and importing the header recognizes Binary Ninja macros without repeated manual selection.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop, reverse-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.