Vector35 / Vector35/binaryninja-api

Setting function type unnecessarily creates user symbol

Open
#5,879 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Core Effort: Low Impact: Low
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 4.2.5916-dev
  • OS: macOS
  • OS Version: 15.1 Beta (24B5024e)
  • CPU Architecture: M3

Bug Description:
Setting a function's type resets its symbol data, removing the symbol's raw name, full name, etc.

Steps To Reproduce:
Click on the function and press Y, then specify the new function type and then click accept. The symbol data will now be reset.

Expected Behavior:
The raw name, full name, etc should be kept intact and only the function type should be changed.

Screenshots/Video Recording:
Screenshot 2024-08-24 at 11 47 33
Screenshot 2024-08-24 at 11 48 09
Screenshot 2024-08-24 at 11 48 19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the function-type change triggered by selecting a function, pressing Y, and accepting the new type. Reproduce the issue on macOS, then verify that changing the type preserves the symbol's raw name, full name, and other symbol data while changing only the function type.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.