Vector35 / Vector35/binaryninja-api

Stack string detection combines multiple short strings into a longer one

Open
#5,816 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Core Effort: Medium Impact: Medium
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

In the following screenshot, we can see there are multiple null-terminated strings on the stack:

Screenshot 2024-08-02 at 5 46 09 PM

However, the stack string detection combines them and thinks it is a longer string:

Screenshot 2024-08-02 at 5 47 21 PM

We should either automatically detect the case and create multiple strings from it, or, at least offer a way to override the behavior of the stack string detection and make it possible for the user to fix the situation

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the stack string detection behavior described in the issue using multiple null-terminated strings on the stack and inspect the relevant detection entry point. Done means the strings are detected separately, or users have a way to override the combined result.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.