Vector35 / Vector35/binaryninja-api

Type information for `Direct3DCreate9` is wrong

Open
#5,800 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Type Libraries Effort: Low Impact: Low
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

The Direct3DCreate9 returns a pointer to IDirect3D9 structure. However, our type library thinks it returns a IDirect3D9 structure (instead of a pointer to it).

Screenshot 2024-07-27 at 4 12 47 PM

We can also see the inferred type from the API call is busted:

Screenshot 2024-07-27 at 4 13 09 PM [CrackME.exe.zip](https://github.com/user-attachments/files/16398713/CrackME.exe.zip)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the type-library definition and API entry for Direct3DCreate9, then compare its declared return type with the IDirect3D9 pointer described in the issue. Done means the type library and inferred API-call type both represent a pointer to IDirect3D9; the payload names no specific file or test to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.