Vector35 / Vector35/binaryninja-api
Nested if-else not converted to early returns -- causing very long indention
Open
Nobody has claimed this yet.
Component: Core
Core: HLIL
Effort: Low
Impact: Low
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
In the screenshot, the code has a lot of indention and makes it harder to read as code goes on (not shown). They should be converted to early returns to reduce the indention and make the code more readable:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting BEDaisy.sys.zip and the screenshot to locate the affected nested if-else code in the repository. Trace the surrounding behavior before refactoring; done means the relevant control flow uses early returns with less indentation while preserving existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- reverse-engineering
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100