Vector35 / Vector35/binaryninja-api

Improve vtable handling

Open
#5,759 5 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Low Impact: Low
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 4.1.5747-dev Personal, 7558ffe9
  • OS: manjaro
  • CPU Architecture: x86_64

Bug Description:
There are a few improvements which could be made to the handling of vtables.

  1. If I double click a vtable member with only one outgoing data reference it should open the referenced function.
    Currently it opens the type window instead.

  2. If I click on a vtable member function it should show its callers as code references. At the moment I have to go back to the vtable in the data section to the get the callers.

Steps To Reproduce:

  1. Double click a member of a vtable.

  2. Check xrefs on a member of a vtable

Expected Behavior:

  1. It opens the referenced function

  2. The cross reference view is populated with the callers of the function as code references.

Screenshots:

  1. Double click issue:
    vtable

  2. Xrefs not propagated
    missing_xrefs

Additional Information:
Bndb and exe used.
CppTestBinja.zip

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by opening the supplied CppTestBinja.zip reproduction in Binary Ninja and inspect the vtable member navigation and cross-reference behavior described in the issue. Verify both expected outcomes: a single outgoing data reference opens the referenced function, and callers appear as code references when viewing the vtable member. Done means both behaviors work for the provided reproduction.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.