Vector35 / Vector35/binaryninja-api

sometimes "e" on a single line shows multi-line assembly popup

Open
#5,733 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Trivial Impact: Low
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

I suspect the root cause of this is that during certain navigation events more than a single visible address is actually navigated to? Not totally sure just know that at least 3-4 times I'll hit "e" on what is visually a single address but I'll get the multiline popup instead.
Screenshot 2024-07-12 at 15 13 22

One way to repro it appears to be:

  • select multiple lines, hit e, get the multiline popup
  • double-click a different search result to navigate somewhere else, see only a single line is selected
  • hit "e" and still get the popup

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported sequence in Binary Ninja: select multiple lines and press "e", double-click another search result, then press "e" with one visible line selected. Inspect the selection state carried across navigation and the assembly popup decision. Done means a single-line selection opens the single-line popup while a multiline selection still opens the multiline popup.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop-dev, reverse-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.