Vector35 / Vector35/binaryninja-api

Merging types breaks refs on conflicts

Open
#5,722 0 comments 0 reactions 1 assignee View on GitHub

@CouleeApps is already working on this.

Since Jul 26, 2024.

Component: Merge Conflict Edition: Ultimate Effort: Low Impact: Medium State: Blocked (Issue)
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

If I have:

struct bbbb {        
    int aaaa;        
}                    
struct aaaa {        
    struct bbbb aaaa;
}                    

...defined newly on both sides of a merge, it should merge into two structs with suffixes and updated references:

struct bbbb_1 {            struct bbbb_2 {
    int aaaa;                  int aaaa;
}                          }
struct aaaa_1 {            struct aaaa_2 {
    struct bbbb_1 aaaa;        struct bbbb_2 aaaa;
}                          }

It does the two structs with suffixes part correctly, but leaves the inner member still pointing to bbbb which no longer exists.

Blocked by #5720.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.