Vector35 / Vector35/binaryninja-api

Stack sidebar `Choose Base Offset...` action not undoable

Open
#5,704 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Effort: Trivial Impact: Low UI: Stack
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Looks as though the new (as of 4.1) Choose Base Offset... and presumably Choose Base Register... actions in the StackView are not undoable.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the StackView implementation and the handlers for Choose Base Offset... and Choose Base Register.... Trace how their state changes are recorded, then verify that each action supports undo and redo without losing the selected base.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.