Vector35 / Vector35/binaryninja-api

Swtiching to HLIL from disassembly can cause the linear view to go to a wrong address

Open
#5,503 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Low Impact: Low UI: Linear
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 4.1.5408-dev Personal (64723166)
  • OS: Windows 10
  • OS Version: 22H2
  • CPU Architecture: x64

Bug Description:
Please provide a clear and concise description of what happened.

Switching views between HLIL and Disassembly using TAB key may relocate the highlighted lines elsewhere.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Use https://docs.binary.ninja/files/taped binary
  2. Go to 0x8049522
  3. Make sure you are viewing the disassembly in the linear view
  4. Switch to HLIL using TAB key
  5. Observe the line 0x80494d0 is selected
  6. Press Tab again to switch back
  7. Notice now it highlights the line at 0x80494d0

Expected Behavior:

highlighted lines should be somewhere relevant to their IL form.

Screenshots:

https://github.com/Vector35/binaryninja-api/assets/4518763/9cfc8d39-957b-4268-8cf9-81128dcd66bd

Additional Information:
Please add any other context about the problem here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Binary Ninja 4.1.5408-dev on the provided taped binary, navigating to 0x8049522 in the disassembly linear view. Toggle between disassembly and HLIL with Tab and observe the selection moving to 0x80494d0. Done means switching views keeps the highlighted line at a relevant corresponding location.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.