Vector35 / Vector35/binaryninja-api

HLIL shouldn't propagate string constants from read/write data

Open
#5,421 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Core Effort: Low Impact: Medium
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 4.1.5261-dev Personal (859dedd4)

Bug Description:
HLIL will sometimes replace a writable data variable that contains a string with the value of the string.

Steps To Reproduce:
I believe this is enough:

image
image

Expected Behavior:
HLIL displays the assignment as data_1800b6088[0] = 0 or something.

HLIL displays the read (rcx_1 = ...) as rcx_1 = *data_1800b6088 or something.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the HLIL behavior using the supplied description and screenshots, focusing on writable data variables that contain strings. Compare the displayed assignment and read with the expected indirect data accesses. Done means HLIL no longer substitutes the string constant and instead shows the writable data variable or dereference as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.