Vector35 / Vector35/binaryninja-api

Failing to parse auto-generated function signature

Open
#5,327 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Type Parser Effort: Medium Impact: Low
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 4.0.4958, ddff9339
  • OS: macos
  • OS Version: 14.4
  • CPU Architecture: arm64

BN internal database: major dine favor

Bug Description:

00012d5c          x0_3, v0_1, v1_1, v2_1, v3_1, v4_1, v5_1, v6_1, v7_1 = DjiUser_FillInUserInfo(userInfo: &userInfo)
00012d6c          if (x0_3 != 0)

The Change Type dialog fails to parse its own type spec. It puts the structure definition in the signature

long unsigned int DjiUser_FillInUserInfo(struct { char appName[0x20]; char appId[0x10]; char appKey[0x20]; char appLicense[0x200]; char developerAccount[0x40]; char baudRate[0x7]; }* userInfo)

Related to #5325.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Change Type dialog and trace how it parses the auto-generated function signature shown in the report. Compare the behavior with related issue #5325 and reproduce it using the provided anonymous-structure signature. Done means the dialog accepts the signature without embedding the full structure definition incorrectly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.