Vector35 / Vector35/binaryninja-api
PseudoC fails to add cast to signed comparisons
Open
Nobody has claimed this yet.
Component: Core
Effort: Low
Impact: Medium
LanguageRep: Pseudo-C
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
In HLIL (left) the display is correct. In PseudoC on the right the comparison is incorrect.
Special Thanks to: Zao Yang and Stefan Nagy for their research in Decompiler Fuzzing for reporting this issue.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining the attached orig_state_exec.zip and comparing the shown HLIL with the PseudoC output for the signed comparison. Trace the decompiler path that renders this comparison and verify that the generated PseudoC includes the appropriate cast and matches the HLIL semantics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers, reverse-engineering
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100