Vector35 / Vector35/binaryninja-api

(VERY MINOR) Binary Ninja opens non-maximised even if maximised when closed

Open
#5,137 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Trivial Impact: Low
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 4.0.4911-stable
  • OS: windows
  • OS 10
  • CPU Architecture: x64

Bug Description:
Prior to upgrade if binary ninja was maximised and closed it would stay maximised when re-opened, since upgrade to 4 it always opens non-maximised

Steps To Reproduce:
Open binary ninja
Maximise window
Close binary ninja
Reopen and window will not be maximised

Expected Behavior:
Open binary ninja
Maximise window
Close binary ninja
Reopen and window will be maximised

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. First reproduce the issue on Windows 10 x64 with Binary Ninja 4.0.4911-stable by maximizing, closing, and reopening the application, then trace the desktop window-state persistence entry point. Done means a maximized window reopens maximized after being closed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.