Edit>Find focuses searchbox instead of popping find dialog

Open
#5,109 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
macos
Domain
desktop

Research direction

Start by tracing the Edit > Find menu action and the Cmd+F behavior when a strings view pane is open. Reproduce the issue on macOS, then verify that the menu opens the Find dialog while Cmd+F continues to focus the searchbox.

Written by the indexing model from the issue text.

Description

Component: UI Effort: Trivial Impact: Low

Version and Platform (required):

  • Binary Ninja Version: 4.0.4906
  • OS: macOS
  • OS Version: 14
  • CPU Architecture: x86_64

Bug Description:
When using Edit > Find from the menu, but with a strings view pane open, it focuses the searchbox instead of opening the find dialog. This is mildly surprising because i expected Edit>Find to always open the Find dialog, but it does make sense that Cmd+F would have focused the searchbox and the menu item is just doing that instead.

Steps To Reproduce:

  1. Open a binary
  2. Open strings view (not the sidebar)
  3. Use menu: Edit > Find
  4. Observe focus
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.