Vector35 / Vector35/binaryninja-api

Simplify common conditional expression

Open
#5,074 9 comments 3 reactions 1 assignee View on GitHub

@D0ntPanic is already working on this.

Since Mar 5, 2024.

Component: Core Core: HLIL IL Optimization Impact: Low
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

I'm seeing a lot of this type of condition repeated that should be easy to simplify

(!A || (A && B)) Which simplifies down to just !A || B
Similarly
(A || (!A && B)) => A || B

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.